refactor: Fix compilation warnings across multiple crates

- Remove unused imports (Filter, Digest, Resource, etc.)
- Prefix unused variables with underscore (_pk, _size)
- Fix snake_case naming for local variables
- Remove unused ArgumentError enum in pmoupnp
- Apply cargo fix suggestions for unused imports

Remaining warnings are async_fn_in_trait style warnings which
would require API breaking changes to address.

pmoupnp/src/actions/action_instance.rs

@@ -1,10 +1,8 @@
 use std::{
     collections::{HashMap, HashSet},
-    env::var,
     sync::Arc,
 };
 
-use bevy_reflect::Reflect;
 use xmltree::{Element, XMLNode};
 
 use crate::actions::{Action, ActionData, ActionInstance, ArgInstanceSet};

pmoupnp/src/actions/action_methods.rs

@@ -1,6 +1,6 @@
 use std::sync::Arc;
 
-use tracing::{info, trace};
+use tracing::info;
 use xmltree::{Element, XMLNode};
 
 use crate::actions::{Action, ActionHandler, ActionInstance, Argument, ArgumentSet};

pmoupnp/src/actions/errors.rs

@@ -17,21 +17,3 @@ impl From<std::io::Error> for ActionError {
         ActionError::GeneralError(format!("IO error: {}", err))
     }
 }
-
-#[derive(Error, Debug)]
-pub enum ArgumentError {
-    #[error("Argument error: {0}")]
-    GeneralError(String),
-
-    #[error("Argument error: {0}")]
-    ArgumentError(String),
-
-    #[error("Set operation error: {0}")]
-    SetError(String),
-}
-
-impl From<std::io::Error> for ArgumentError {
-    fn from(err: std::io::Error) -> Self {
-        ArgumentError::GeneralError(format!("IO error: {}", err))
-    }
-}

pmoupnp/src/services/service_methods.rs

@@ -47,21 +47,21 @@ impl UpnpObject for Service {
         elem.children.push(XMLNode::Element(service_id));
 
         // SCPDURL
-        let mut SCPDURL = Element::new("SCPDURL");
-        SCPDURL.children.push(XMLNode::Text(self.scpd_route()));
-        elem.children.push(XMLNode::Element(SCPDURL));
+        let mut scpdurl = Element::new("SCPDURL");
+        scpdurl.children.push(XMLNode::Text(self.scpd_route()));
+        elem.children.push(XMLNode::Element(scpdurl));
 
         // controlURL
-        let mut controlURL = Element::new("controlURL");
-        controlURL
+        let mut control_url = Element::new("controlURL");
+        control_url
             .children
             .push(XMLNode::Text(self.control_route()));
-        elem.children.push(XMLNode::Element(controlURL));
+        elem.children.push(XMLNode::Element(control_url));
 
         // eventSubURL
-        let mut eventSubURL = Element::new("eventSubURL");
-        eventSubURL.children.push(XMLNode::Text(self.event_route()));
-        elem.children.push(XMLNode::Element(eventSubURL));
+        let mut event_sub_url = Element::new("eventSubURL");
+        event_sub_url.children.push(XMLNode::Text(self.event_route()));
+        elem.children.push(XMLNode::Element(event_sub_url));
 
         elem
     }