push-yvskvtsqsmxs #97

eric · 2026-04-12T21:10:15+02:00

eric commented

2026-04-12 21:10:15 +02:00

No description provided.

eric added 5 commits 2026-04-12 21:10:16 +02:00

🚀 refactor(pmocontrol): eliminate QueueBackend boilerplate with HasQueue blanket impl 9e447023a8

- Add `Hasqueue` trait and implement it for all renderers (Upnp, OpenHome, LinkPlay, ArylicTcp, Chromecast)
- Replace manual `QueueBackend` implementations with blanket impl for types implementing Hasqueue
  (removes ~30+ duplicated methods across renderers)
- Fix BUG: `sync_queue` in UpnpRenderer now correctly propagates cancel_token instead of ignoring it
- Update version to 0.3.48 in Cargo.toml, lockfile and root file
- Add refactoring plan document (`refactoring_pmocontrol.md`) detailing remaining P1-P3 tasks

refactor: replace unwrap() with expect for mutex locks 4b793cec59

Replace all `lock().unwrap()` calls on Mutex guards with explicit error messages using `.expect("... mutex poisoned")`. This improves robustness by providing clear diagnostics when a thread panics while holding the lock, preventing silent failures. Affected modules: events.rs (Renderer/MediaServer), all renderer backends, queue backend/implementation files. Also adds documentation to marker traits (HasQueue、 HasContinuousStream) and clarifies error handling in watcher loop with panic catching.

♻️ refactor queue control methods into trait default impls 8ddee7d94f

Remove duplicate `play_from_queue`, ` play_next `,  
`play_previous , and
``
pay _from_index implementations across all renderers (ArylicTcp, Chromecast,
LinkPlay , OpenHome UPnP) and instead provide default implementations in the
`QueueTransportControl `trait. Also introduce dispatch macros to simplify backend delegation for Transport/Volume control, and expose parse_didl_duration as public(crate).

♻️ refactor stream detection and queue sync logic 82197c8103

- Replace `is_continuous_stream_url` with new canonical check using metadata + fallback
- Extract stream duration comparison logic to `queue::stream_duration_*` helpers  
- Improve queue sync concurrency: add worker loop, pending/cancel flags
- Make `stream_duration_*` functions public(crate) for reuse

Replace unwrap() with expect("mutex poisoned") across all mutex locks 39d7c56a99

- Replace `.lock().unwrap()` with explicit error messages for poisoned MutexGuard
- Improve robustness against mutex poisoning in renderer, queue and event subsystems

eric merged commit 9ad7d7454d into main

2026-04-12 21:10:24 +02:00

eric deleted branch push-yvskvtsqsmxs

2026-04-12 21:10:24 +02:00

eric referenced this issue from a commit

2026-04-12 21:10:25 +02:00

Merge pull request 'push-yvskvtsqsmxs' (#97) from push-yvskvtsqsmxs into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eric/pmomusic#97