push-lluwzruwyool #20

Closed
eric wants to merge 1 commits from push-lluwzruwyool into main
Owner
No description provided.
eric added 180 commits 2025-11-05 00:43:03 +01:00
This commit contains the following changes:
     A .DS_Store
     A .pmomusic.yml
     A .vscode/settings.json
     A db/chroma.sqlite3
Reviewed-on: #2
Reviewed-on: #3
Reviewed-on: #4
Reviewed-on: #5
Reviewed-on: #6
Reviewed-on: #7
Reviewed-on: #8
Reviewed-on: #9
This commit contains the following changes:
     M .gitignore
     A Cargo.lock
     A Cargo.toml
     A PMOMusic/Cargo.toml
     A PMOMusic/src/main.rs
     D README.md
     A Readme.md
Reviewed-on: #10
Reviewed-on: #12
Reviewed-on: #13
Reviewed-on: #14
Reviewed-on: #16
reprise du module DSP pmoaudio
Reviewed-on: #19
- Remove .pmomusic.yml from git tracking (contains passwords)
- Add .pmomusic.yml.example as template without sensitive data
- Add SECURITY_CONFIG.md with setup instructions
- Credentials should be configured locally or via environment variables

This change prevents accidental exposure of Qobuz credentials.
Users must copy .pmomusic.yml.example to .pmomusic.yml and
configure their own credentials.
Resolved compilation error where netstat2 v0.9.1 was accessing
tcp_info.state instead of tcp_info.tcpi_state on Linux systems.
The latest version 0.11.2 includes the fix for this field name change.
- Remove unused imports (Filter, Digest, Resource, etc.)
- Prefix unused variables with underscore (_pk, _size)
- Fix snake_case naming for local variables
- Remove unused ArgumentError enum in pmoupnp
- Apply cargo fix suggestions for unused imports

Remaining warnings are async_fn_in_trait style warnings which
would require API breaking changes to address.
- Add Node::logic_mut() method to allow post-construction configuration
  of node logic before run() is called
- Fix FlacCacheSink to properly transfer playlist_handle_pending to
  the inner logic using logic_mut()
- Resolves FIXME at flac_cache_sink.rs:656 about missing logic_mut()

This enables the playlist registration mechanism to work correctly:
1. User calls register_playlist() on FlacCacheSink
2. Handle is stored in playlist_handle_pending
3. During run(), handle is transferred to FlacCacheSinkLogic
4. Tracks are automatically added to playlist after caching
Improve the architecture by configuring the playlist handle directly
in register_playlist() instead of deferring it to run().

Changes:
- Remove playlist_handle_pending field (no longer needed)
- register_playlist() now calls logic_mut() to configure immediately
- run() becomes a simple delegation with no configuration logic
- Follows proper pattern: configuration before run(), not during run()

This is cleaner than the previous approach which used a pending field
and transferred it during run(). The new approach:
1. User calls register_playlist() → directly configures logic
2. User calls run() → simple delegation to inner.run()

Architecture now properly separates configuration from execution.
Claude/pmomusic development 011 c uob cda nz ao k8 vxmg85n p
eric closed this pull request 2025-12-27 14:39:24 +01:00

Pull request closed

Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eric/pmomusic#20
No description provided.