push-kvzwrolnknzx #86

eric · 2026-04-04T12:58:54+02:00

eric commented

2026-04-04 12:58:54 +02:00

No description provided.

eric added 13 commits 2026-04-04 12:58:55 +02:00

✨ add async_trait support for UpnpApiExt trait and impl 54ea7b5813

- Add `async-trait` dependency import
- Annotate UpnpApiExt trait and its Server impl with `#[async_trait]` to enable async methods in traits

correct compilation warning in pmoqobuz 6352a43e27

:sparkles!: add async-trait dependency for WebAppExt trait d81e7a9413

- Add `async_trait` as an optional依赖ency in pmoapp/Cargo.toml
- Enable usage of `#[async_trait]` on WebAppExt trait and its impl for Server
- Guard async-related code with `#[cfg(feature = "pmoserver")]`

🔧 fix unused variable warning and suppress must-use lint in macros 34260e7cbd

- Prefix `_object_id` parameter with underscore to silence unused variable warning in `get_item`
- Add #[allow(unused_must_use)] to all action macro definitions in pmoupnp/macros.rs
- Remove redundant doc comment line break

🗑️ Remove unused imports and format code 77d0d73ed7

- Comment out `use std::simd::*` in pmoaudio as it's unused and modules import their own SIMD
- Remove `Instant` from imports in track_metadata.rs (unused)
- Reorder anyhow import to match Rust convention (`anyhow, Result` → `Result`) and remove unused imports
- Improve XML response logging readability with line breaks in iterator chain
+ Refactor `get()` method to multi-line for clarity and consistency

🔧 Add #[allow(dead_code)] to unused items ff699d220f

- Suppress dead code warnings for utility functions, enums and traits not yet used in production
- Reorganize imports to follow module conventions (e.g., `DeviceIdentity` moved earlier in openhome_renderer.rs)
- Improve formatting of ClientMessage variants for readability
These changes prepare codebase groundwork without altering runtime behavior.

🔧 refactor(base_url): centraliser gestion des URLs absolues via middleware 718c0d2aed

- Ajout d'un BaseUrl layer dans pmoserver pour gérer les URLs absolues (LAN/WAN)
- Renommage de `covers_absolute_url_for` → ` covers_relative_route`, stocker les routes relatives
- Mise à jour des appels UPnP vers `covers_absolute_url_for_upnp` (fallback PMO_SERVER_URL)
- Correction des tâches de fond pour stocker les routes, pas l'URL complète
- Suppression du feature gate `simd` inutilisé dans pmoaudio/src/lib.rs

✨ Add cover proxy for external LAN media servers bdaee820ad

- Implement new /covers/proxy endpoint to cache and rewrite external LAN cover URLs
- Add url/urlencoding dependencies for URL parsing/escaping in pmocontrol and pmocovers Cargo.toml
- Transform album_art_uri fields to use proxy endpoint for LAN URLs in REST and SSE handlers (browse_container, MetadataChanged)
- Add URL validation logic to detect LAN vs public URLs and avoid self-caching
- Update Cargo.lock with new dependencies

✨ Add pmocovers integration for external cover URL proxying ea5936717a

- Introduce optional `pmocover` dependency in pmocontrol
- Add cover URL transformation logic for both REST and SSE endpoints using `pmocovers::proxy_cover_url`/sync
- Refactor `/covers/proxy?...=` handler to accept any external URL and return local cached route
- Implement helper functions `transform_cover_url` (async) & sync variant for consistent cover URL normalization
- Update Cargo.lock to include `pmocovers`

🎨 Simplify album art URL transformation logic 21ea77eadc

Refactor queue item cover image handling to directly access `album_art_uri` from the top-level struct instead of nested metadata, and update return type to use fully qualified path `crate::openapi::QueueSnapshot` for clarity.

(feat) Use async cover URL transformation in SSE endpoints e0ef485e04

- Replace sync proxy_cover_url_sync calls with async versions using dedicated tokio runtime in transformCoverUrlSync
- Update comments to reflect usage of asynchronous logic for cover URL transformation

⬆️ refactor(sse): migrate event processing to fully async 97a82f4e1d

- Convert `renderer_event_to_payload` and `media_server_sse::event_handler`s to async
- Replace sync cover URL transformation with `.await` on `transform_cover_url`
- Remove blocking thread-based workarounds for async execution
-	Improve SSE scalability and responsiveness by eliminating nested runtimes

🔖 version bump to v0.3.29 6fcecaab00

- Bump crate and file versions from `v0.3.29` to v\[correction: actually 0\.3\.33] (see Cargo.toml & version.txt)
- Extend cover URL transformation logic to queue items in `pmoserver_ext.rs`—now transforms album art for both current track *and* queue items
- Add debug logging to cover URL transformation steps (local route, instance match & proxy)
- Minor cleanup: remove redundant `clone()` in base_url usage

eric merged commit 33b279ff1e into main

2026-04-04 12:59:11 +02:00

eric deleted branch push-kvzwrolnknzx

2026-04-04 12:59:11 +02:00

eric referenced this issue from a commit

2026-04-04 12:59:12 +02:00

Merge pull request 'push-kvzwrolnknzx' (#86) from push-kvzwrolnknzx into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eric/pmomusic#86